fix(avro): parse decimals with shorter bytes correctly #16202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
See risingwavelabs/avro#3. In short, given
decimal(10, 2)
it would need 5 bytes to store its maximum. When decoding an actual decimal with 4 or few bytes (e.g. simply0
or42
), the upstream library reports an error (wrong comparison due to misconception similar to the missing dollar riddle).Actual fix is in the forked library, while this PR just bumps the commit and adds a test. To test
decimal
(a logical type overbytes
in avro), we had to update the test input format: it used to be plain json but switches to the json encoding (contrasting to binary encoding in kafka) of avro. The first commit of this PR is this pure test-refactor but not a standalone PR to ease cherry-picking into release branch.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.