-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend, meta): support RECOVER
command to trigger recovery
#16259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwannoel
force-pushed
the
kwannoel/trigger-recovery
branch
from
April 11, 2024 09:20
27b06c8
to
8b3f112
Compare
kwannoel
force-pushed
the
kwannoel/trigger-recovery
branch
from
April 15, 2024 04:06
8b3f112
to
abf7fc9
Compare
yezizp2012
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx for the PR.
kwannoel
added
the
user-facing-changes
Contains changes that are visible to users
label
Apr 15, 2024
BugenZhao
reviewed
Apr 15, 2024
1 task
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci/run-e2e-single-node-tests
type/feature
user-facing-changes
Contains changes that are visible to users
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Closes #14700
The current shortcoming of this approach is that while recovery is triggered, the command does not wait for recovery to complete, it operates in an async way. Welcome any ideas for improvement. If not we can improve it later.
Path of recover command:
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
The user can use the command:
RECOVER
to trigger an adhocrecovery
. This can be used in cases where barrier latency is high, and we want to force a recovery to kick-in, so commands likecancel, drop
can immediately take effect.