Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): upsert+protobuf source #18301

Merged
merged 2 commits into from
Aug 28, 2024
Merged

fix(connector): upsert+protobuf source #18301

merged 2 commits into from
Aug 28, 2024

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Aug 28, 2024 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix #17624

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@zwang28 zwang28 changed the title Wangzheng/fix upsert protobuf fix(connector): upsert+protobuf source Aug 28, 2024
@github-actions github-actions bot added type/fix Bug fix and removed Invalid PR Title labels Aug 28, 2024
tabVersion
tabVersion approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, really appreciate

@graphite-app graphite-app bot requested a review from a team August 28, 2024 09:56
@zwang28 zwang28 added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit 14a46ff Aug 28, 2024
33 of 35 checks passed
@zwang28 zwang28 deleted the wangzheng/fix_upsert_protobuf branch August 28, 2024 10:44
github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
@zwang28 @tabVersion
fix(connector): upsert+protobuf source (#18301)
322ae5c 
Co-authored-by: Bohan Zhang <tabvision@bupt.icu>
@github-actions github-actions bot mentioned this pull request Sep 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 24, 2024
@github-actions @zwang28 @tabVersion
fix(connector): upsert+protobuf source (#18301) (#18658)
a55e500 
Co-authored-by: zwang28 <70626450+zwang28@users.noreply.github.com>
Co-authored-by: Bohan Zhang <tabvision@bupt.icu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabVersion tabVersion tabVersion approved these changes

@xiangjinwu xiangjinwu Awaiting requested review from xiangjinwu

Assignees
No one assigned
Labels
need-cherry-pick-release-2.0 type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zwang28 @tabVersion