refactor: bump toolchain to 2024-07-19

[MrCroxx]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

The rust toolchain version 1.81.0 is stable, which was branched from 2024-07-19.

Let's bump our toolchain version. Otherwise we cannot use lib whose MSRV is stable 1.81.0.

Checklist

• I have written necessary rustdoc comments
• I have added necessary unit tests and integration tests
• I have added test labels as necessary. See details.
• I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
• My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
• All checks passed in ./risedev check (or alias, ./risedev c)
• My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

• My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

• My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

[MrCroxx]

The opaque is !Unpin, which cannot be treat as pub type GooglePubSubSinkDeliveryFuture = impl TryFuture<Ok = (), Error = SinkError> + Unpin + 'static;

cc @xxhZs @wenym1

[xxchan]

As mentioned in #17179, we might need to change all TAITs to bump toolchain... (unless rust-lang/rust#128440 is landed)

more changes ongoing

[MrCroxx]

😳 FIrst time seeing this.

[wenym1]

Rest LGTM.

Do we consider bumping to the latest toolchain by the way?

[wenym1]

Do we forget the rotate_right(17)?

[MrCroxx]

IIUC, with u32 and 17 + 15 = 32, this operation equals to directly rotate_left(15). (clippy also recommends it.

[wenym1]

As mentioned in #17179, we might need to change all TAITs to bump toolchain... (unless rust-lang/rust#128440 is landed)

Actually it's not that many. I have fixed all the involved TAIT.

[MrCroxx]

risingwave/src/frontend/src/optimizer/rule/index_selection_rule.rs

Lines 965 to 974 in d0f47d1

	#[derive(Default)]
	struct ExprInputRefFinder {
	pub input_ref_index_set: HashSet<usize>,
	}
	impl ExprVisitor for ExprInputRefFinder {
	fn visit_input_ref(&mut self, input_ref: &InputRef) {
	self.input_ref_index_set.insert(input_ref.index);
	}
	}

@chenzl25 Is this code still using? It seems a dead code.

[MrCroxx]

https://buildkite.com/risingwavelabs/pull-request/builds/57645#0191dac7-247a-4bc7-9185-5d0c3993b6bb

@xxchan How to bump rust toolchain for https://github.com/risingwavelabs/clippy?

UPDATES: Found the docs, let me try.

[MrCroxx]

UPDATES: dylint fixed via risingwavelabs/clippy#1

[xxchan]

Thank you!!

Remember to bump CI image before merging, so that we don't install rust toolchain repeatedly in CI

[xxchan]

Wait, I think we can bump to a newer version. No need to stick to latest stable 🤔

[MrCroxx]

Wait, I think we can bump to a newer version. No need to stick to latest stable 🤔

Agreed. Let me try nightly-2024-09-10. BTW, are you familiar with the the issue in the madsim integration test?

info: syncing channel updates for 'nightly-2024-07-19-x86_64-unknown-linux-gnu'
info: latest update on 2024-07-19, rust version 1.81.0-nightly (5affbb171 2024-07-18)
info: downloading component 'cargo'
error: component download failed for cargo-x86_64-unknown-linux-gnu

Caused by:
    could not rename downloaded file from '/root/.rustup/downloads/724035a7625f76dc52925fc2e8858e9d2c7ce6c4b31a8dd15bb57b9154590abb.partial' to '/root/.rustup/downloads/724035a7625f76dc52925fc2e8858e9d2c7ce6c4b31a8dd15bb57b9154590abb'

Stack backtrace:
   0: rustup::dist::manifestation::Manifestation::update
   1: rustup::dist::dist::try_update_from_dist_
   2: rustup::install::InstallMethod::install
   3: rustup::toolchain::distributable::DistributableToolchain::install
   4: rustup::config::Cfg::find_or_install_override_toolchain_or_default
   5: rustup::cli::proxy_mode::main
   6: rustup_init::main
   7: std::sys_common::backtrace::__rust_begin_short_backtrace
   8: main
   9: <unknown>
  10: __libc_start_main
  11: <unknown>

The instance keep failing fetching the components of the toolchain over and over again. Is it related to the CI image?

[MrCroxx]

Let me try nightly-2024-09-10.

There are some false-positive cases with elided named lifetime.

[MrCroxx]

Let's just upgrade the toolchain to 2024-07-19. I need it for some stable crates with 1.81.0.