-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dup split assignment in source #18541
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuyufjh
reviewed
Sep 16, 2024
fuyufjh
reviewed
Sep 16, 2024
fuyufjh
approved these changes
Sep 16, 2024
shanicky
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
Co-authored-by: tabversion <tabversion@bupt.icu>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
prev #18134 (#18157, #18158) does not fix the case completely.
In the prev fix, we check each mutation and removed the dup one from the assignment. But we have no way to know the prev assignment and it can cause the dup assignment as well.
Giving a more concrete example here
T0: actor_1(split_1, split_2), actor_2(split_3)
and we have a dup assignment, the mutation looks like
{"actor_1"; ["split_1, split_2"], "actor_2": [split_2, split_3]}
, after the check impl, the mutation may look like{"actor_1"; ["split_1], "actor_2": [split_2, split_3]}
as we RANDOMLY remove the dup split from the assignment.So actor_1 knows it should remove split_2 but it still needs to write the latest offset to the storage. But actor_2 ought to write split_2 with the initial offset to the storage to mark it as applying the change successfully.
As a result, we get a dup write on the same key and same epoch panic in the compactor.
This pr handles this case by wrapping the dup split detected split_change_mutation with pause/resume. Separating the two writes to different epoches.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.