feat: deprecate etcd meta store #18621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yezizp2012
force-pushed
the
chore/switch-e2e-sql-backend
branch
from
2c55798 to
a59de4c
Compare
5 tasks
yezizp2012
requested review from
fuyufjh,
wenym1,
zwang28,
kwannoel and
shanicky
yezizp2012
commented
Oct 14, 2024
| } | ||
| } | ||
| // #[cfg(test)] | ||
| // mod tests { |
There was a problem hiding this comment.
Cc @zwang28 , I commented out all unit tests about backup and restore, which is using MetaSnapshotV1. Please switch it to use sql backend after this PR get merged.
fuyufjh
approved these changes
Oct 14, 2024
zwang28
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.