feat(sink): add json encode for file sink #18744
Merged
+140
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcy-fdu
commented
Sep 30, 2024
| assert_eq!(op, Op::Insert, "expect all `op(s)` to be `Op::Insert`"); | ||
| // to prevent temporary string allocation, | ||
| // so we directly write to `chunk_buf` implicitly via `write_fmt`. | ||
| writeln!( |
There was a problem hiding this comment.
in snowflake sink, there are no line breaks between lines, but the file sink has.(I think it's more friendly with user).
There was a problem hiding this comment.
Has it been tested to import snowflake?
There was a problem hiding this comment.
No, I plan to deprecate snowflake sink in next pr, this pr only focus on file sink.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
The implementation detail is almost the same with snowflake sink, and the difference is
uuidto distinguish the parallelism, while the file sink directly usesexecutor_id.Todo:
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
Add json encode for file sink, which allow user to sink json files into object storage.
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.