Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdc): fix the filter expression of CdcFilter executor #18868

Merged
merged 9 commits into from
Oct 16, 2024

Conversation

StrikeW
Copy link
Contributor

@StrikeW StrikeW commented Oct 11, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Change the filter expression to filter upstream source chunk by the value of _rw_table_name, which is prefixed by the schema name of the table. e.g. public.t1.
The previous expression only filter by table name w/o schema name.

close #17890

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

After this PR, use needs to prefix the upstream table name with database name. e.g.

CREATE TABLE shared_orders (
    order_id INT,
    order_date BIGINT,
    customer_name VARCHAR,
    price DECIMAL,
    product_id INT,
    order_status SMALLINT,
    PRIMARY KEY (order_id)
)  from mssql_source table 'mydb.dbo.wrong_orders';

@github-actions github-actions bot added the type/fix Bug fix label Oct 11, 2024
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we also add a e2e test?

Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

Copy link

gitguardian bot commented Oct 15, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9425213 Triggered Generic Password 82598ce ci/scripts/e2e-source-test.sh View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@graphite-app graphite-app bot requested a review from a team October 15, 2024 13:46
@StrikeW StrikeW requested a review from KeXiangWang October 15, 2024 14:53
@KeXiangWang
Copy link
Contributor

🤔 Will there be compatibility issue?

@@ -235,6 +235,7 @@ var record = event.value();
// - PG: topicPrefix.schemaName.tableName
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't PG have the same issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can see in the comment, the pg connector doesn't prefixed with database name.
PG: topicPrefix.schemaName.tableName

@StrikeW
Copy link
Contributor Author

StrikeW commented Oct 16, 2024

🤔 Will there be compatibility issue?

For already created sqlserver cdc table, it should be fine since it will use old implementation persisted in meta store. But new table needs to prefix the upstream table with database name.

@KeXiangWang
Copy link
Contributor

Please help update the doc correspondingly. Thanks!

@StrikeW StrikeW added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 04755fd Oct 16, 2024
32 of 34 checks passed
@StrikeW StrikeW deleted the siyuan/fix-cdc-source-filter branch October 16, 2024 04:29
github-merge-queue bot pushed a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres CDC: upstream table in different schema will sync into same Table
3 participants