-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve observability for subscription/cursor SHOW commands #18896
Merged
+158
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Examples:
|
xxhZs
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
hzxa21
added a commit
that referenced
this pull request
Nov 5, 2024
hzxa21
added a commit
that referenced
this pull request
Nov 5, 2024
hzxa21
pushed a commit
that referenced
this pull request
Nov 8, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Limitations for subscription/cursor SHOW commands prior to this PR:
SHOW CURSORS
/SHOW SUBSCRIPTION CURSORS
only show cursor names in the current session where the show command is run.After this PR:
SHOW CURSORS
/SHOW SUBSCRIPTION CURSORS
output all cursor information across active sessions in the same frontend node.SHOW CURSORS
outputsId | User | Host | Database | Cursor Name
SHOW SUBSCRIPTION CURSORS
outputsId | User | Host | Database | Cursor Name | Subscription Name | State | Idle Duration Ms
SHOW SUBSCRIPTIONS
outputsName | Retention Seconds
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
Enhance
SHOW
command for subscription and subscription cursor:SHOW CURSORS
/SHOW SUBSCRIPTION CURSORS
output all cursor information across active sessions in the same frontend node.SHOW CURSORS
outputsId | User | Host | Database | Cursor Name
SHOW SUBSCRIPTION CURSORS
outputsId | User | Host | Database | Cursor Name | Subscription Name | State | Idle Duration Ms
SHOW SUBSCRIPTIONS
outputsName | Retention Seconds