Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump java dependencies #19208

Merged
merged 17 commits into from
Nov 17, 2024
Merged

chore: bump java dependencies #19208

merged 17 commits into from
Nov 17, 2024

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Oct 30, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolve #19165

Exclusions:

  • Debezium should never be bumped because it's so important and we have hacked its source code (#18760)
  • Protobuf is staying at 3.x because gRPC's compatibility. Update to Protobuf 4.x grpc/grpc-java#11015.
    • The issue above said the protobuf-java 4.x is compatible but it doesn't work for me. Will investigate later.
  • MongoDB client was not bumped because it needs some code changes. See commit message of cc46cbd.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@fuyufjh
Copy link
Member Author

fuyufjh commented Nov 12, 2024

Unfortunately it's harder than I thought. The risingwave-connector-test module depends on 2 big projects: Spark (DeltaLake) and Flink, and it's hard to reconcile their dependencies.

Particularly, Jackson Databind has a very restricted version requirement.

DeltaLakeLocalSinkTest.testSync:97->validateTableWithSpark:58 » Execution com.fasterxml.jackson.databind.JsonMappingException: Scala module 2.13.4 requires Jackson Databind version >= 2.13.0 and < 2.14.0 - Found jackson-databind version 2.15.0

I will try to split these test cases into their own module first.

@fuyufjh fuyufjh mentioned this pull request Nov 13, 2024
9 tasks
Exception in thread "rw-dbz-engine-runner-7" java.lang.NoSuchMethodError: 'com.mongodb.connection.SocketSettings$Builder com.mongodb.connection.SocketSettings$Builder.connectTimeout(int, java.util.concurrent.TimeUnit)'
	at io.debezium.connector.mongodb.connection.client.DefaultMongoDbClientFactory.lambda$createMongoClientSettings$0(DefaultMongoDbClientFactory.java:43)
	at com.mongodb.MongoClientSettings$Builder.applyToSocketSettings(MongoClientSettings.java:362)
	at io.debezium.connector.mongodb.connection.client.DefaultMongoDbClientFactory.createMongoClientSettings(DefaultMongoDbClientFactory.java:42)
	at io.debezium.connector.mongodb.connection.client.DefaultMongoDbClientFactory.<init>(DefaultMongoDbClientFactory.java:28)
	at io.debezium.connector.mongodb.connection.MongoDbConnectionContext.<init>(MongoDbConnectionContext.java:42)
	at io.debezium.connector.mongodb.MongoDbConnector.validateConnection(MongoDbConnector.java:124)
	at io.debezium.connector.mongodb.MongoDbConnector.validate(MongoDbConnector.java:104)
	at io.debezium.embedded.EmbeddedEngine.getConnectorConfig(EmbeddedEngine.java:512)
	at io.debezium.embedded.EmbeddedEngine.run(EmbeddedEngine.java:422)
	at io.debezium.embedded.ConvertingEngineBuilder$1.run(ConvertingEngineBuilder.java:163)
	at com.risingwave.connector.source.core.DbzCdcEngine.run(DbzCdcEngine.java:67)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:840)
@fuyufjh fuyufjh added this pull request to the merge queue Nov 17, 2024
Merged via the queue into main with commit 0519b3f Nov 17, 2024
31 of 33 checks passed
@fuyufjh fuyufjh deleted the eric/bump_java_dependencies branch November 17, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vulneribilities found in docker scout for nightly-20241028
3 participants