Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(barrier): not cache actor failure in local barrier worker #19367

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Nov 13, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously we cache the actor failure so that if the newly spawned actor failed before the inject barrier request, we can know about the failure and return error. However, after we change to spawn new actors along with the inject barrier request, this becomes unnecessary. Besides, we reset the streaming control stream immediately after we receive any actor failure. Therefore, there is no need to cache the actor failure in local barrier worker any more.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wenym1 wenym1 added this pull request to the merge queue Nov 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024
@wenym1 wenym1 added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 0ddb6eb Nov 13, 2024
29 of 30 checks passed
@wenym1 wenym1 deleted the yiming/no-store-actor-failure branch November 13, 2024 07:31
wenym1 added a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants