Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iceberg): support rest authentication #19406

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Nov 15, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Example:

CREATE SOURCE iceberg_t1
WITH (
    connector = 'iceberg',
    s3.endpoint = 'https://s3.ap-southeast-2.amazonaws.com',
    s3.region = 'ap-southeast-2',
    s3.access.key = 'xxxx',
    s3.secret.key = 'xxxx',
    s3.path.style.access = 'true',
    catalog.type = 'rest',
    catalog.uri = 'http://localhost:8181/api/catalog',
    warehouse.path = 'quickstart_catalog',
    database.name = 'ns',
    table.name = 't1',
    catalog.credential='123456:123456',
    catalog.scope='PRINCIPAL_ROLE:ALL',
    catalog.oauth2-server-uri='xxx'
    catalog.scope='xxx',
);

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

  • Allow to specify catalog.credential, catalog.scope, catalog.oauth2-server-uri, and catalog.scope for iceberg rest catalog.

@chenzl25 chenzl25 requested review from xxchan and Li0k November 15, 2024 10:33
@chenzl25 chenzl25 requested a review from xxhZs November 15, 2024 10:34
@chenzl25 chenzl25 added the user-facing-changes Contains changes that are visible to users label Nov 15, 2024
@chenzl25 chenzl25 added this pull request to the merge queue Nov 21, 2024
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the rest

if warehouse_path.ends_with('/') {
let url = Url::parse(warehouse_path);
if url.is_err() {
// For rest catalog, the warehouse_path could be a warehouse name.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we use another option for warehouse name?

The rustdoc of warehouse_path says "only applicable in storage catalog"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, spark uses warehouse key to allow users to specify warehouse name or warehouse path. However, in our system, we use warehouse.path instead. Maybe we should use a warehouse alias.

Merged via the queue into main with commit e544337 Nov 21, 2024
33 of 34 checks passed
@chenzl25 chenzl25 deleted the dylan/support_rest_authentication branch November 21, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Support Iceberg rest authentication
3 participants