-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iceberg): support rest authentication #19406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the rest
if warehouse_path.ends_with('/') { | ||
let url = Url::parse(warehouse_path); | ||
if url.is_err() { | ||
// For rest catalog, the warehouse_path could be a warehouse name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we use another option for warehouse name?
The rustdoc of warehouse_path
says "only applicable in storage catalog"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, spark uses warehouse
key to allow users to specify warehouse name or warehouse path. However, in our system, we use warehouse.path instead. Maybe we should use a warehouse alias.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Example:
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
catalog.credential
,catalog.scope
,catalog.oauth2-server-uri
, andcatalog.scope
for iceberg rest catalog.