-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(streaming): support adaptive backfill rate limit #19743
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
May add some demo for it to show it works well. |
Sure. I'm reading the slts in #16678 to see what scenarios we need to test. |
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
I am wondering if |
I think the problem is tick the rate limiter per barrier. I think it can be refactored to tick for each loop or future selection. 🤔 |
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
How's it going? |
This PR validates the effectiveness and feasibility of the adaptive rate limiter. In order to improve maintainability, I need one to two PRs to refactor the code part of the rate limiter. PTAL: #19967 🙏 |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
WIP
close #16678
slt test
UPDATE: There is some mistakes in the screenshots. I'll fix it and update it later.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.