Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(streaming): support adaptive backfill rate limit #19743

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Dec 10, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

WIP

close #16678

slt test

UPDATE: There is some mistakes in the screenshots. I'll fix it and update it later.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx self-assigned this Dec 10, 2024
@MrCroxx MrCroxx marked this pull request as ready for review December 10, 2024 09:16
@kwannoel
Copy link
Contributor

May add some demo for it to show it works well.

@kwannoel kwannoel self-requested a review December 11, 2024 03:21
@MrCroxx
Copy link
Contributor Author

MrCroxx commented Dec 11, 2024

May add some demo for it to show it works well.

Sure. I'm reading the slts in #16678 to see what scenarios we need to test.

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@tabVersion
Copy link
Contributor

I am wondering if cur_barrier_snapshot_processed_rowsa lagging indicator and does not reflect the back pressure rate in time.

@MrCroxx
Copy link
Contributor Author

MrCroxx commented Dec 14, 2024

I am wondering if cur_barrier_snapshot_processed_rowsa lagging indicator and does not reflect the back pressure rate in time.

I think the problem is tick the rate limiter per barrier. I think it can be refactored to tick for each loop or future selection. 🤔

@MrCroxx MrCroxx requested a review from hzxa21 December 16, 2024 03:55
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Copy link
Contributor

How's it going?

@MrCroxx
Copy link
Contributor Author

MrCroxx commented Jan 2, 2025

How's it going?

This PR validates the effectiveness and feasibility of the adaptive rate limiter. In order to improve maintainability, I need one to two PRs to refactor the code part of the rate limiter.

PTAL: #19967 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants