Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add graph check in risectl for sql meta store #19764

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

shanicky
Copy link
Contributor

@shanicky shanicky commented Dec 11, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

run ctl meta graph-check

If there are no issues, it will exit with status code 0; if there are problems, it will print the logs and exit with status code 1.

sample error logs

2024-12-11T16:23:20.279723+08:00 ERROR risingwave_meta::controller::scale: Integrity check failed: Fragment 249088 has different upstream_fragment_ids from discovered: {} != {249089, 249092}
2024-12-11T16:23:20.279797+08:00 ERROR risingwave_meta::controller::scale: Integrity check failed: Fragment 246009 has different upstream_fragment_ids from discovered: {} != {223031}
2024-12-11T16:23:20.279828+08:00 ERROR risingwave_meta::controller::scale: Integrity check failed: Fragment 249084 has different upstream_fragment_ids from discovered: {} != {181025}
2024-12-11T16:23:20.279865+08:00 ERROR risingwave_meta::controller::scale: Integrity check failed: Fragment 258005 has different upstream_fragment_ids from discovered: {} != {181025}
...

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Shanicky Chen <peng@risingwave-labs.com>
… chars)

Signed-off-by: Shanicky Chen <peng@risingwave-labs.com>
…e message

Signed-off-by: Shanicky Chen <peng@risingwave-labs.com>
@shanicky shanicky requested a review from yezizp2012 December 11, 2024 11:37
@shanicky shanicky added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 9dff1ac Dec 20, 2024
35 of 36 checks passed
@shanicky shanicky deleted the peng/scale-check-tools branch December 20, 2024 08:22
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
Signed-off-by: Shanicky Chen <peng@risingwave-labs.com>
github-merge-queue bot pushed a commit that referenced this pull request Jan 8, 2025
Signed-off-by: Shanicky Chen <peng@risingwave-labs.com>
Co-authored-by: Shanicky Chen <peng@risingwave-labs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants