feat(types): support ns timestamp #19827
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuyufjh
reviewed
Dec 18, 2024
|
I tested whether I could read nanosecond in the parquet file on this branch, and it seemed to work. |
|
sorry, mis clicked update branch |
|
cc @xiangjinwu PTAL❤️ |
xiangjinwu
reviewed
Dec 19, 2024
| ) | ||
| } | ||
| let dt = s | ||
| .parse::<jiff::civil::DateTime>() |
There was a problem hiding this comment.
Why do we need to introduce yet another dependency in addition to chrono and speedate?
| @@ -495,18 +491,47 @@ impl Timestamp { | |||
| } | |||
|
|
|||
| pub fn from_protobuf(cur: &mut Cursor<&[u8]>) -> ArrayResult<Timestamp> { | |||
| let micros = cur | |||
| let secs = cur | |||
Comment on lines
+524
to
+534
| fn add_timestamp_namo_format_state(value: i64) -> i64 { | ||
| value ^ (0b01 << 62) | ||
| } | ||
|
|
||
| fn has_timestamp_namo_format_state(value: i64) -> bool { | ||
| let state = (value >> 62) & 0b11; | ||
| state == 0b10 || state == 0b01 | ||
| } | ||
|
|
||
| fn remove_timestamp_namo_format_state(value: i64) -> i64 { | ||
| value ^ (0b01 << 62) |
There was a problem hiding this comment.
Encapsulate as a new type:
/// document about old and new format, including the meaning of highest 2 bits, and the corresponding accepted ranges.
enum FirstI64 {
V0{ usecs: i64 }
V1{ secs: i64 }
}
impl From<i64> for FirstI64 {
// check and remove the tagging bits
}
impl From<FirstI64> for i64 {
// add the tagging bits
}
| @@ -495,7 +495,7 @@ impl HummockVersion { | |||
| .clone_from(&group_construct.table_ids); | |||
| self.levels.insert(*compaction_group_id, new_levels); | |||
| let member_table_ids = if group_construct.version | |||
| >= CompatibilityVersion::NoMemberTableIds as _ | |||
| >= CompatibilityVersion::NoMemberTableIds as i32 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
our timestamp only support ms, But our internal implementation is capable of ns, it's just that we automatically convert it to ms when we read it in, and this pr can read ns to support ns.
Checklist
Documentation
Release note