fix(frontend): check data type in column id generator #19828
+182
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BugenZhao
force-pushed
the
bz/col-id-gen-aware-of-type
branch
from
0583ff4 to
f191ab0
Compare
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
force-pushed
the
bz/col-id-gen-aware-of-type
branch
from
46ded5b to
b0bc757
Compare
xiangjinwu
approved these changes
Dec 19, 2024
Comment on lines
+2030
to
+2033
| &Field::with_name( | ||
| StructType::new([("f1", DataType::Int32)]).into(), | ||
| "nested", | ||
| ), |
There was a problem hiding this comment.
Yet another example of why Field::sub_fields (and ColumnDesc::field_descs) shall be consolidated into StructType. Currently Field::with_name on struct produces incomplete results - and there is a special Field::with_struct.
No need to fix the usage in this PR as the incomplete results are NEVER used except describe #17128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
When generating column ID for existing columns (by name), also check and reject if the data type changes. Otherwise, the persisted data will be incompatible and lead to undefined behavior.
Note that for struct types, the nested fields are encoded with value-encoding (instead of column-aware encoding) under current implementation. As a result, adding new nested fields cannot be supported and should be rejected as well. Close #19736.
This won't be hit for a regular table as we don't provide syntax support for altering the data type for an existing column. However, schema registries may consider this as a compatible change so it can be hit by
ALTER TABLE REFRESH SCHEMA.Checklist
Documentation
Release note