fix: Fix the panic issue with the parallelism() call #19849
Merged
+39
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type/fix
shanicky
added
need-cherry-pick-release-2.2
and removed
type/fix
yezizp2012
approved these changes
Dec 18, 2024
xxchan
approved these changes
Dec 18, 2024
stdrc
reviewed
Dec 20, 2024
src/prost/src/lib.rs
Outdated
| @@ -221,13 +221,21 @@ impl stream_plan::MaterializeNode { | |||
|
|
|||
| // Encapsulating the use of parallelism. | |||
| impl common::WorkerNode { | |||
| pub fn parallelism(&self) -> usize { | |||
| pub fn compute_parallelism(&self) -> usize { | |||
There was a problem hiding this comment.
Does this new name look like "computing" the parallelism when it's called? What about cn_parallelism or cnode_parallelism?
There was a problem hiding this comment.
Indeed, I originally wanted to call it streaming_parallelism, but I found that serving node is also using that term. Later, I thought about naming it compute_node_parallelism, but it seems a bit long.
I'll make a change.
…ptional Signed-off-by: Shanicky Chen <peng@risingwave-labs.com>
…nsistency across modules.
shanicky
force-pushed
the
peng/parallelism-panic
branch
from
31f3808 to
8bc9659
Compare
github-actions
bot
added
type/fix
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
Signed-off-by: Shanicky Chen <peng@risingwave-labs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In theory, only compute nodes should have the concept of parallelism, so invoking
parallelism()for other types of workers is meaningless and should not be done.This pull request renames the original
parallelismtocompute_parallelismand adds a newparallelismreturn option to prevent potential misuse.Checklist
Documentation
Release note