fix(meta): skip unnecessary delta persistence #19878
Open
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
During commit_epoch for newly created table, a
GroupConstruct
delta is expected, which triggers a false alarm. The alarm was added to assert onlyNewL0SubLevel
delta was kept for time travel.This PR resolves this issue by skipping delta contaning
GroupConstruct
for time travel, because for that delta a complete version snapshot is ensured to be created for time travel, based onshould_mark_next_time_travel_version_snapshot
. This redundant delta has never been used.Checklist
Documentation
Release note