-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(meta): inform executors of the vnodes they own #2887
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2887 +/- ##
==========================================
- Coverage 72.90% 72.89% -0.01%
==========================================
Files 703 703
Lines 93151 93196 +45
==========================================
+ Hits 67910 67939 +29
- Misses 25241 25257 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* feat(meta): inform executors of the vnodes they own * remove maplen field in VNodeBitmap and move it to common.proto * use bitmap instead of Vec<Vnode> * fmt proto * refine code
What's changed and what's your intention?
Summarize your change
StreamActor
proto in meta. Executors in one actor share the same set of vnodes, so in this way, stream executors can know the vnodes they own.schedule()
.Checklist
Refer to a related PR or issue link
This PR should work with #2882 to enable vnode pruning. Specifically, a stateful executor should use the vnode info it gets from meta in this PR to initialize its keyspace.