Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grafana): use Python script to generate dashboard #2979

Merged
merged 6 commits into from
Jun 6, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Jun 4, 2022

Signed-off-by: Alex Chi iskyzh@gmail.com

What's changed and what's your intention?

As title. No more JSON conflicts!

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

close #2953

Signed-off-by: Alex Chi <iskyzh@gmail.com>
skyzh added 2 commits June 4, 2022 14:39
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh changed the title feat(grafana): use Python script to generate dashbaord feat(grafana): use Python script to generate dashboard Jun 4, 2022
@skyzh skyzh enabled auto-merge (squash) June 4, 2022 06:44
@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #2979 (d3741a9) into main (60203cd) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2979      +/-   ##
==========================================
- Coverage   72.87%   72.86%   -0.01%     
==========================================
  Files         722      722              
  Lines       96610    96610              
==========================================
- Hits        70401    70398       -3     
- Misses      26209    26212       +3     
Flag Coverage Δ
rust 72.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/model/barrier.rs 78.57% <0.00%> (-3.58%) ⬇️
src/meta/src/hummock/mock_hummock_meta_client.rs 50.00% <0.00%> (-1.29%) ⬇️
src/storage/src/hummock/local_version_manager.rs 90.06% <0.00%> (-0.16%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

skyzh added 3 commits June 4, 2022 15:02
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh requested review from hzxa21 and Little-Wallace June 6, 2022 02:20
@skyzh skyzh merged commit 485874d into main Jun 6, 2022
@skyzh skyzh deleted the skyzh/refactor-grafana-dashboard branch June 6, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grafana: use Jsonnet to configure Grafana dashboard
2 participants