feat(build): link openssl statically

[skyzh]

Signed-off-by: Alex Chi iskyzh@gmail.com

What's changed and what's your intention?

Statically link openssl.

Need to test if works with s3.

Checklist

• I have written necessary docs and comments
• I have added necessary unit tests and integration tests
• All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

close #2973

[skyzh]

Basically, enabling statically linked openssl is as easy as

openssl = { version = "0.10", features = ["vendored"] }

However, this change involves too many other changes, like enabling cert discovery by ourselves. So I'd close this and see if we really need statically link openssl in the future. Indeed, we can use rustls instead.

[skyzh]

~/risingwave$ ldd target/debug/risingwave
        linux-vdso.so.1 (0x00007fff97fae000)
        libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007fea8225c000)
        libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fea8223c000)
        libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fea82155000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fea81f2d000)
        /lib64/ld-linux-x86-64.so.2 (0x00007fea8c8ef000)

[skyzh]

Tested and works with s3. However, unit test OOM. We should have a flag to enable / disable statically linked openssl...

[skyzh]

There're still bugs with cargo-hakari that prevents setting the feature flag. Need to report to upstream 😇

[github-actions]

license-eye has totally checked 821 files.

Valid	Invalid	Ignored	Fixed
819	1	1	0

Click to see the invalid file list

• src/utils/static-link/src/lib.rs

[github-actions]

Suggested change

	#[cfg(test)]
	// Copyright 2022 Singularity Data
	//
	// Licensed under the Apache License, Version 2.0 (the "License");
	// you may not use this file except in compliance with the License.
	// You may obtain a copy of the License at
	//
	// http://www.apache.org/licenses/LICENSE-2.0
	//
	// Unless required by applicable law or agreed to in writing, software
	// distributed under the License is distributed on an "AS IS" BASIS,
	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
	// See the License for the specific language governing permissions and
	// limitations under the License.
	#[cfg(test)]

[skyzh]

Also a bug with rustc. It seems that compile RisingWave 1. with static-link 2. and then without it will cause linker to panic. Anyway, cargo clean always works.

[codecov]

Codecov Report

Merging #2984 (600cfb9) into main (2110778) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2984   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files         720      721    +1     
  Lines       96471    96472    +1     
=======================================
+ Hits        70400    70401    +1     
  Misses      26071    26071           

Flag	Coverage Δ
rust	72.97% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/utils/static-link/src/lib.rs	100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more