Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(kinesis): Correct assume_role_external_id spelling in Kine… #3016

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Conversation

ryanrussell
Copy link
Contributor

…sis Connector

Signed-off-by: Ryan Russell git@ryanrussell.org

What's changed and what's your intention?

assume_role_externeal_id -> assume_role_external_id

	modified:   src/connector/src/kinesis/config.rs
	modified:   src/connector/src/kinesis/mod.rs
	modified:   src/connector/src/kinesis/source/reader.rs

Checklist

  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

…sis Connector

Signed-off-by: Ryan Russell <git@ryanrussell.org>
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #3016 (14e969a) into main (c2a84f2) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #3016   +/-   ##
=======================================
  Coverage   73.15%   73.15%           
=======================================
  Files         724      724           
  Lines       97191    97191           
=======================================
  Hits        71097    71097           
  Misses      26094    26094           
Flag Coverage Δ
rust 73.15% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connector/src/kinesis/config.rs 0.00% <0.00%> (ø)
src/connector/src/kinesis/mod.rs 0.00% <ø> (ø)
src/connector/src/kinesis/source/reader.rs 0.00% <0.00%> (ø)
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️
src/meta/src/model/barrier.rs 82.14% <0.00%> (+3.57%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@lmatz lmatz merged commit 5024d71 into risingwavelabs:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants