-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): add metrics for barrier latency at each stage #3965
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3965 +/- ##
==========================================
- Coverage 74.33% 74.32% -0.01%
==========================================
Files 844 844
Lines 122336 122407 +71
==========================================
+ Hits 90939 90985 +46
- Misses 31397 31422 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Would you please take a screenshot of the metrics? I didn't start it by myself for now, but I have some ideas for how to display this. We can have multiple panels, e.g. Barrier In-Flight p50, Barrier In-Flight p99. In each of the panel, we stack https://grafana.com/docs/grafana/next/visualizations/time-series/graph-time-series-stacking/ This might help us better understand what's going on. |
|
Would you please add some comments about the new-introduced metrics to explain what duration it is measuring? Or the name looks kind of confusing. 🥰 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM. I think we can merge this PR after addressing all comments.
@Mergifyio refresh |
✅ Pull request refreshed |
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
…avelabs#3965) * add metrics * remove * add doc * add docs Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Add barrer_inflight_latency, barrier_sync_latency, and barrier_wait_commit_latency. We can know how much time these stages take.
And add sync_size_every_epoch, we can know the size of S3 written by each epoch
Checklist
./risedev check
(or alias,./risedev c
)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)