Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta): provide SST id to worker id mapping in commit_epoch. #4285

Merged
merged 3 commits into from
Aug 1, 2022

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Jul 29, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

So that commit_epoch can validate input SSTs.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #4285 (d21cb74) into main (c488659) will increase coverage by 0.02%.
The diff coverage is 82.70%.

@@            Coverage Diff             @@
##             main    #4285      +/-   ##
==========================================
+ Coverage   74.31%   74.33%   +0.02%     
==========================================
  Files         844      844              
  Lines      122011   122117     +106     
==========================================
+ Hits        90675    90781     +106     
  Misses      31336    31336              
Flag Coverage Δ
rust 74.33% <82.70%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/compute/src/rpc/service/stream_service.rs 0.00% <0.00%> (ø)
src/meta/src/hummock/compaction_scheduler.rs 20.17% <0.00%> (ø)
src/meta/src/hummock/error.rs 2.50% <0.00%> (-0.14%) ⬇️
src/meta/src/rpc/service/hummock_service.rs 6.57% <0.00%> (ø)
src/rpc_client/src/meta_client.rs 0.00% <0.00%> (ø)
src/meta/src/hummock/hummock_manager.rs 84.91% <70.96%> (-0.45%) ⬇️
src/meta/src/barrier/mod.rs 84.05% <81.25%> (+0.28%) ⬆️
src/meta/src/hummock/compactor_manager.rs 97.86% <85.71%> (+0.03%) ⬆️
src/meta/src/hummock/hummock_manager_tests.rs 91.03% <88.65%> (+2.48%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 43.10% <100.00%> (+2.03%) ⬆️
... and 8 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@zwang28 zwang28 marked this pull request as ready for review July 29, 2022 07:42
@zwang28 zwang28 requested a review from hzxa21 July 29, 2022 07:43
# Conflicts:
#	proto/stream_service.proto
#	src/meta/src/barrier/mod.rs
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM

@mergify mergify bot merged commit 34c99c0 into main Aug 1, 2022
@mergify mergify bot deleted the wangzheng/carray_worker_id branch August 1, 2022 03:57
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
…isingwavelabs#4285)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants