Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): only schedule dml to cn which contain table source writer #4329

Merged
merged 5 commits into from
Aug 1, 2022

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Aug 1, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title, we should only schedule dml to CNs which contains table source writer. When new CN joined, schedule dml to new node will failed due to no writer and downstream mview exist.

Note that, I will move vnode_mapping out of TableCatalog described in #3449 in next PR and modify schedule single/multi policy together.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.

Refer to a related PR or issue link (optional)

Resolve #4328

@yezizp2012 yezizp2012 changed the title fix: only schedule dml to cn contains table source writer fix: only schedule dml to cn which contain table source writer Aug 1, 2022
@yezizp2012 yezizp2012 changed the title fix: only schedule dml to cn which contain table source writer fix(frontend): only schedule dml to cn which contain table source writer Aug 1, 2022
@github-actions github-actions bot added the type/fix Bug fix label Aug 1, 2022
@BugenZhao BugenZhao requested a review from st1page August 1, 2022 09:22
@yezizp2012 yezizp2012 requested a review from BugenZhao August 1, 2022 09:34
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #4329 (77ad93c) into main (6bf43fe) will decrease coverage by 0.01%.
The diff coverage is 26.47%.

@@            Coverage Diff             @@
##             main    #4329      +/-   ##
==========================================
- Coverage   74.33%   74.32%   -0.02%     
==========================================
  Files         844      844              
  Lines      122446   122474      +28     
==========================================
+ Hits        91021    91028       +7     
- Misses      31425    31446      +21     
Flag Coverage Δ
rust 74.32% <26.47%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/handler/dml.rs 0.00% <0.00%> (ø)
...rontend/src/scheduler/distributed/query_manager.rs 9.52% <0.00%> (-1.10%) ⬇️
src/frontend/src/scheduler/worker_node_manager.rs 74.44% <0.00%> (-1.97%) ⬇️
src/frontend/src/binder/update.rs 68.18% <75.00%> (-0.08%) ⬇️
src/frontend/src/binder/insert.rs 94.64% <100.00%> (+0.30%) ⬆️
src/meta/src/manager/id.rs 95.10% <0.00%> (-0.55%) ⬇️
src/connector/src/source/filesystem/file_common.rs 80.80% <0.00%> (+0.44%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot merged commit 650221e into main Aug 1, 2022
@mergify mergify bot deleted the fix/schedule-single branch August 1, 2022 09:57
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
…ter (risingwavelabs#4329)

* fix: only schedule dml to cn contains table source writer

* fix duplicate bind

* choose

* fix

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: should schedule dml to CNs which contain the target table source writer
3 participants