-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): only schedule dml to cn which contain table source writer #4329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #4329 +/- ##
==========================================
- Coverage 74.33% 74.32% -0.02%
==========================================
Files 844 844
Lines 122446 122474 +28
==========================================
+ Hits 91021 91028 +7
- Misses 31425 31446 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
…ter (risingwavelabs#4329) * fix: only schedule dml to cn contains table source writer * fix duplicate bind * choose * fix Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title, we should only schedule dml to CNs which contains table source writer. When new CN joined, schedule dml to new node will failed due to no writer and downstream mview exist.
Note that, I will move
vnode_mapping
out ofTableCatalog
described in #3449 in next PR and modify schedule single/multi policy together.Checklist
./risedev check
(or alias,./risedev c
)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)
Resolve #4328