-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(meta): support manual compaction for specific sst ids from CN #4338
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4338 +/- ##
=======================================
Coverage 74.47% 74.47%
=======================================
Files 846 846
Lines 123271 123278 +7
=======================================
+ Hits 91804 91813 +9
+ Misses 31467 31465 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
b7c0088
to
71b9196
Compare
I do not understand. It means that meta-node does not trigger L0 compaction for CN ? |
And if one compute-node crash down, each state of one CN may be scheduled to several different CN. Could you change the CN id which it assigned ? |
the new CN will trigger those compaction |
we do not assign anything in meta. each CN itself will request meta to trigger compaction |
for Non-Overlapping sub-level, meta will trigger L0 compaction for them |
71b9196
to
a763997
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manual compaction for specific sst ids is LGTM,if needed we can merge this PR first
Manual compaction on specific SST ids is a good-to-have feature in case admin needs to mitigate production issues when our compaction strategy doesn't work. However, whether or not to allow CNs to trigger L0 intra compaction is debatable. IMO, it is better to avoid that for simplicity. |
https://singularity-data.quip.com/1qKlAaCBNeO0/RFC-maintaining-L0-SST-index-in-CN |
…isingwavelabs#4338) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
support manual compaction for specific sst ids from CN, so as that CNs can trigger L0 intra compaction which exactly contains SSTs that generated by itself. see also #4072
Checklist
Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)