Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(planner): Use explain verbose for all planner tests #4359

Merged
merged 5 commits into from
Aug 2, 2022

Conversation

jon-chuang
Copy link
Contributor

@jon-chuang jon-chuang commented Aug 2, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

The current behaviour is not to explain verbose in planner tests, we thereby do not capture: node distributions, fully qualified column names, and output indices in joins.

This PR will use explain verbose in all planner tests.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #4359 (ff77d45) into main (fa06647) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4359      +/-   ##
==========================================
+ Coverage   74.32%   74.42%   +0.10%     
==========================================
  Files         846      846              
  Lines      122993   122994       +1     
==========================================
+ Hits        91413    91537     +124     
+ Misses      31580    31457     -123     
Flag Coverage Δ
rust 74.42% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/test_runner/src/lib.rs 74.20% <100.00%> (+0.08%) ⬆️
src/meta/src/manager/id.rs 94.56% <0.00%> (-1.09%) ⬇️
...ntend/src/optimizer/plan_node/stream_index_scan.rs 27.27% <0.00%> (ø)
src/connector/src/source/filesystem/file_common.rs 80.80% <0.00%> (+0.44%) ⬆️
...rc/frontend/src/optimizer/property/distribution.rs 86.45% <0.00%> (+0.64%) ⬆️
...c/frontend/src/optimizer/plan_node/logical_join.rs 90.53% <0.00%> (+1.60%) ⬆️
...frontend/src/optimizer/plan_node/batch_seq_scan.rs 93.42% <0.00%> (+4.60%) ⬆️
...c/frontend/src/optimizer/plan_node/logical_scan.rs 95.32% <0.00%> (+4.94%) ⬆️
...ntend/src/optimizer/plan_node/batch_lookup_join.rs 58.06% <0.00%> (+6.45%) ⬆️
...ontend/src/optimizer/plan_node/stream_hash_join.rs 97.81% <0.00%> (+10.38%) ⬆️
... and 3 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@jon-chuang jon-chuang requested a review from st1page August 2, 2022 04:42
Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 4269183 into main Aug 2, 2022
@mergify mergify bot deleted the jon/explain-verbose-planner-tests branch August 2, 2022 08:05
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
…abs#4359)

* use explain verbose

* Use explain verbose

* minor

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants