-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(optimizer): Implement ProjectJoin
rule
#4385
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4385 +/- ##
=======================================
Coverage 74.48% 74.48%
=======================================
Files 846 846
Lines 123826 123832 +6
=======================================
+ Hits 92226 92239 +13
+ Misses 31600 31593 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
…into jon/project-join
IIRC, physical optimization likes |
IIRC, we have support output_indices in executor, what the |
In this case trivial means identity. |
Oh, I just only focus on the pull_filter part which always create a project. No question Now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
related issue #1922
Will we also need to similarly merge simple project into output indices of other nodes? 🤔
Possibly. One of these is scan. I'm not sure if its necessary to do this as it may already be facilitated by prune_cols? Anw, we can open an issue on this. |
…into jon/project-join
* success * success * fix merge main
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Merge projects into joins's output indices where project's expressions are all
InputRef
sChecklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)