Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(batch): Make local mode default #4789

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Conversation

liurenjie1024
Copy link
Contributor

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Make local execution mode default.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • RisingWave cluster configuration changes

Release note

Default batch execution mode changed from distributed to local.

Refer to a related PR or issue link (optional)

#4654

@liurenjie1024 liurenjie1024 added component/batch Batch related related issue. user-facing-changes Contains changes that are visible to users labels Aug 22, 2022
@liurenjie1024 liurenjie1024 requested a review from fuyufjh August 22, 2022 10:07
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #4789 (400a254) into main (0019e59) will decrease coverage by 0.10%.
The diff coverage is 54.25%.

@@            Coverage Diff             @@
##             main    #4789      +/-   ##
==========================================
- Coverage   73.94%   73.83%   -0.11%     
==========================================
  Files         871      871              
  Lines      131548   131846     +298     
==========================================
+ Hits        97267    97346      +79     
- Misses      34281    34500     +219     
Flag Coverage Δ
rust 73.83% <54.25%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/join/lookup_join.rs 56.06% <0.00%> (-0.70%) ⬇️
src/batch/src/task/task_execution.rs 58.46% <ø> (ø)
src/common/src/catalog/mod.rs 70.00% <0.00%> (-2.42%) ⬇️
src/common/src/config.rs 54.01% <ø> (ø)
src/common/src/error.rs 70.53% <ø> (ø)
src/common/src/session_config/query_mode.rs 84.84% <ø> (ø)
src/compute/src/rpc/service/stream_service.rs 0.00% <0.00%> (ø)
src/compute/src/server.rs 0.00% <0.00%> (ø)
src/connector/src/source/pulsar/source/reader.rs 0.00% <0.00%> (ø)
src/meta/src/error.rs 26.92% <0.00%> (-3.52%) ⬇️
... and 46 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit c275f7e into main Aug 22, 2022
@mergify mergify bot deleted the renjie/local_exec_default branch August 22, 2022 10:38
@hengm3467
Copy link
Contributor

@liurenjie1024 Hi Renjie, quick questions: what is the difference between these two modes (local & distributed)? How is it different from batch & streaming mode? Thanks.

@liurenjie1024
Copy link
Contributor Author

@liurenjie1024 Hi Renjie, quick questions: what is the difference between these two modes (local & distributed)? How is it different from batch & streaming mode? Thanks.

Local mode is optimized for highly concurrent, simple point queries.
Distributed mode is optimized for complex queries.

They are both sub mode of batch execution, and is not related to streaming.

@hengm3467
Copy link
Contributor

@liurenjie1024 Thanks a lot for the detailed explanation. It helps a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/batch Batch related related issue. type/refactor user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants