-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(batch): Make local mode default #4789
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4789 +/- ##
==========================================
- Coverage 73.94% 73.83% -0.11%
==========================================
Files 871 871
Lines 131548 131846 +298
==========================================
+ Hits 97267 97346 +79
- Misses 34281 34500 +219
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@liurenjie1024 Hi Renjie, quick questions: what is the difference between these two modes (local & distributed)? How is it different from batch & streaming mode? Thanks. |
Local mode is optimized for highly concurrent, simple point queries. They are both sub mode of batch execution, and is not related to streaming. |
@liurenjie1024 Thanks a lot for the detailed explanation. It helps a lot! |
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Make local execution mode default.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
Release note
Default batch execution mode changed from distributed to local.
Refer to a related PR or issue link (optional)
#4654