refactor(source): merge all inner reader into one stream #5611
Conversation
Signed-off-by: waruto <wmc314@outlook.com>
|
|
waruto210
changed the title
waruto210
changed the title
Codecov Report
@@ Coverage Diff @@
## main #5611 +/- ##
==========================================
- Coverage 74.31% 74.24% -0.08%
==========================================
Files 907 915 +8
Lines 142996 143258 +262
==========================================
+ Hits 106269 106362 +93
- Misses 36727 36896 +169
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| message_tx: Sender<Result<Vec<SourceMessage>>>, | ||
|
|
||
| // merge all streams of inner reader into one | ||
| all_reader_stream: BoxStream<'static, Result<Vec<SourceMessage>>>, |
There was a problem hiding this comment.
How about using type_alias_impl_trait to avoid this Box<dyn>?
There was a problem hiding this comment.
That causes build errors.
There was a problem hiding this comment.
Defining the type alias in a submodule may help this. Anyway, since we yield chunks instead of rows, this won't hurt much.
There was a problem hiding this comment.
Defining the type alias in a submodule may help this. Anyway, since we yield chunks instead of rows, this won't hurt much.
Still an error, I comment it with todo, maybe after this feature is stable.
waruto210
force-pushed
the
merge_all_inner_reader_stream
branch
from
afd6031 to
e93541c
Compare
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Merge all streams of
InnerConnectorSourceReaderinto one stream to avoid spawn too many tasks.Checklist
- [] I have added necessary unit tests and integration tests./risedev check(or alias,./risedev c)