feat(optimizer): refine the conversion from Join to Dynamic Filter #5789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
…port-more-patterns Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
requested review from
jon-chuang,
chenzl25 and
xxchan
and removed request for
jon-chuang and
chenzl25
Codecov Report
@@ Coverage Diff @@
## main #5789 +/- ##
=======================================
Coverage 75.01% 75.01%
=======================================
Files 916 916
Lines 143471 143495 +24
=======================================
+ Hits 107621 107649 +28
+ Misses 35850 35846 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chenzl25
approved these changes
Oct 11, 2022
Comment on lines
+27
to
+33
| - name: | | ||
| With Top-1 on inner side | ||
| TODO: currently not possible due to https://github.com/risingwavelabs/risingwave/issues/5764 | ||
| before: | ||
| - create_tables | ||
| sql: | | ||
| with max_v2 as (select v2 max from t2 order by v2 desc limit 1) select v1 from t1, max_v2 where v1 > max; |
There was a problem hiding this comment.
Some off-topic idea. Maybe we can support more range conditions than simple >, >=, <, <=.
e.g. between
with max_v2 as (select max(v2) max from t2) select v1 from t1, max_v2 where v1 between max - 100 and max + 100;There was a problem hiding this comment.
Exactly, we can support arbitrary range in the future.
st1page
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR refines the conversion from Join to Dynamic Filter.
Also add some planner tests.
Note that some patterns can not be planned now due to pk derivation of hash join. Check the issue below.
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)