Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(log): remove unnecessary warning #5995

Merged
merged 6 commits into from
Oct 24, 2022
Merged

chore(log): remove unnecessary warning #5995

merged 6 commits into from
Oct 24, 2022

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Oct 24, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Before this PR we will observe several misleading warning in meta log. This PR removes unnecessary warning as below

  • It's fine for get_compact_task_impl to return None, if its compaction group is created but not sync_group via commit_epoch, which mean no data for this group is written yet.
  • It's fine for CN to use an inaccurate table_id->compaction_group mapping when commit_epoch, because commit_epoch will correct it.

Checklist

  • I have written necessary rustdoc comments
    - [ ] I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.

Refer to a related PR or issue link (optional)

Copy link
Contributor

@soundOfDestiny soundOfDestiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #5995 (b66613b) into main (d72ba12) will increase coverage by 0.06%.
The diff coverage is 66.99%.

@@            Coverage Diff             @@
##             main    #5995      +/-   ##
==========================================
+ Coverage   74.57%   74.64%   +0.06%     
==========================================
  Files         924      926       +2     
  Lines      147420   147675     +255     
==========================================
+ Hits       109945   110227     +282     
+ Misses      37475    37448      -27     
Flag Coverage Δ
rust 74.64% <66.99%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/source/src/parser/mod.rs 82.22% <0.00%> (ø)
src/storage/hummock_test/src/lib.rs 100.00% <ø> (ø)
...tor/aggregation/agg_impl/approx_distinct_append.rs 0.00% <0.00%> (ø)
...rc/stream/src/executor/aggregation/agg_impl/mod.rs 92.30% <ø> (ø)
src/stream/src/executor/source/source_executor.rs 94.36% <ø> (ø)
src/source/src/parser/pb_parser.rs 51.91% <21.56%> (-6.12%) ⬇️
...utor/aggregation/agg_impl/approx_distinct_utils.rs 85.43% <85.43%> (ø)
src/meta/src/hummock/manager/mod.rs 74.18% <87.50%> (-0.33%) ⬇️
...utor/aggregation/agg_impl/approx_count_distinct.rs 91.23% <92.00%> (+2.05%) ⬆️
src/frontend/src/handler/create_source.rs 79.43% <94.73%> (+1.04%) ⬆️
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2022

Hey @zwang28, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with git commit --allow-empty -m "rerun" && git push.

@BugenZhao
Copy link
Member

#5911

@mergify mergify bot merged commit 8146046 into main Oct 24, 2022
@mergify mergify bot deleted the wangzheng/chore_log branch October 24, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants