fix(binder): resolve array_concat types without intermediate RwError #6171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Construction of
RwError
includes capturing the backtrace, which becomes very slow (~300ms) in single binary debug mode after recent toolchain bump. When we resolve input and output types of the overloadedarray_concat
function, intermediate errors from failed attempts does not need the backtrace. This PR changes these intermediate errors fromRwError
toErrorCode
.Before toolchain bump:
Current main:
This PR:
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)
#6157