Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): avoid pk duplication #7073

Closed
wants to merge 16 commits into from
Closed

feat(frontend): avoid pk duplication #7073

wants to merge 16 commits into from

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Dec 27, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

As title, note that we allow join_key duplication, but avoid join_key and input_pk are duplicated.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.

Refer to a related PR or issue link (optional)

close #6784 #3708

@mergify mergify bot mentioned this pull request Dec 27, 2022
3 tasks
@wcy-fdu wcy-fdu requested review from st1page and yuhao-su and removed request for st1page December 27, 2022 07:42
@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Merging #7073 (86151c6) into main (cf2f7ec) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #7073      +/-   ##
==========================================
- Coverage   73.16%   73.15%   -0.01%     
==========================================
  Files        1052     1052              
  Lines      167382   167403      +21     
==========================================
+ Hits       122468   122472       +4     
- Misses      44914    44931      +17     
Flag Coverage Δ
rust 73.15% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontend/src/stream_fragmenter/rewrite/delta_join.rs 0.00% <0.00%> (ø)
...rc/frontend/src/optimizer/plan_node/generic/agg.rs 76.40% <66.66%> (-0.15%) ⬇️
src/frontend/src/optimizer/plan_node/utils.rs 93.20% <84.61%> (-1.59%) ⬇️
.../src/optimizer/plan_node/generic/dynamic_filter.rs 97.77% <100.00%> (ø)
...frontend/src/optimizer/plan_node/generic/source.rs 92.85% <100.00%> (ø)
.../frontend/src/optimizer/plan_node/generic/top_n.rs 98.36% <100.00%> (+0.08%) ⬆️
src/frontend/src/optimizer/plan_node/stream.rs 13.99% <100.00%> (ø)
...tend/src/optimizer/plan_node/stream_materialize.rs 90.00% <100.00%> (ø)
src/batch/src/executor/group_top_n.rs 68.42% <0.00%> (-6.44%) ⬇️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Contributor

mergify bot commented Dec 27, 2022

Hey @wcy-fdu, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with git commit --allow-empty -m "rerun" && git push.

@mergify
Copy link
Contributor

mergify bot commented Dec 28, 2022

Hey @wcy-fdu, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with git commit --allow-empty -m "rerun" && git push.

@risingwavelabs risingwavelabs deleted a comment from mergify bot Dec 28, 2022
@wcy-fdu wcy-fdu closed this Dec 28, 2022
@wcy-fdu wcy-fdu reopened this Dec 28, 2022
@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Dec 28, 2022

Something went wrong with mergify 😇

@wcy-fdu wcy-fdu closed this Dec 28, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 28, 2022

⚠️ The sha of the head commit of this PR conflicts with #7095. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug(catalog): duplicate columns in pk
3 participants