-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): avoid pk duplication #7073
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7073 +/- ##
==========================================
- Coverage 73.16% 73.15% -0.01%
==========================================
Files 1052 1052
Lines 167382 167403 +21
==========================================
+ Hits 122468 122472 +4
- Misses 44914 44931 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey @wcy-fdu, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with |
Hey @wcy-fdu, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with |
Something went wrong with mergify 😇 |
|
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
As title, note that we allow
join_key
duplication, but avoidjoin_key
andinput_pk
are duplicated.Checklist
./risedev check
(or alias,./risedev c
)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)
close #6784 #3708