Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sql): Remove the ROW FORMAT keyword for CREATE statement of native CDC connectors #7133

Merged
merged 3 commits into from
Dec 30, 2022

Conversation

StrikeW
Copy link
Contributor

@StrikeW StrikeW commented Dec 29, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Remove the ROW FORMAT keyword for CREATE statement of native CDC connectors, which must be debezium json format.

create materialized source orders (
   order_id int,
   order_date timestamp,
   customer_name string,
   price decimal,
   product_id int,
   order_status smallint,
   PRIMARY KEY (order_id)
) with (
 connector = 'mysql-cdc',
 hostname = '127.0.0.1',
 ...
) row format debezium_json <-- removed

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • Connector (sources & sinks)
  • SQL commands, functions, and operators

Release note

Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.

Refer to a related PR or issue link (optional)

@StrikeW StrikeW added the user-facing-changes Contains changes that are visible to users label Dec 29, 2022
@StrikeW StrikeW marked this pull request as ready for review December 29, 2022 14:40
@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #7133 (c7a0dde) into main (b8bdfdf) will increase coverage by 0.00%.
The diff coverage is 87.50%.

@@           Coverage Diff           @@
##             main    #7133   +/-   ##
=======================================
  Coverage   73.19%   73.20%           
=======================================
  Files        1051     1051           
  Lines      167467   167473    +6     
=======================================
+ Hits       122583   122598   +15     
+ Misses      44884    44875    -9     
Flag Coverage Δ
rust 73.20% <87.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sqlparser/src/lib.rs 100.00% <ø> (ø)
src/sqlparser/src/ast/statement.rs 70.22% <87.50%> (+0.20%) ⬆️
...frontend/src/scheduler/hummock_snapshot_manager.rs 58.60% <0.00%> (-0.47%) ⬇️
src/object_store/src/object/mem.rs 86.74% <0.00%> (-0.38%) ⬇️
src/object_store/src/object/mod.rs 51.29% <0.00%> (-0.22%) ⬇️
src/common/src/cache.rs 97.54% <0.00%> (+0.22%) ⬆️
src/batch/src/executor/group_top_n.rs 74.85% <0.00%> (+6.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 7d5d505 into main Dec 30, 2022
@mergify mergify bot deleted the siyuan/cdc-source branch December 30, 2022 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants