Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta): unify create_table with create_stream_job #7266

Merged
merged 4 commits into from
Jan 10, 2023

Conversation

BugenZhao
Copy link
Member

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Remove the create_table_inner and unify it into create_stream_job.
  • Extract a visit_fragment utility and use it for filling source IDs / streaming job IDs.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #7266 (e24e792) into main (5d25f9c) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #7266      +/-   ##
==========================================
+ Coverage   73.01%   73.03%   +0.01%     
==========================================
  Files        1066     1066              
  Lines      170202   170172      -30     
==========================================
  Hits       124277   124277              
+ Misses      45925    45895      -30     
Flag Coverage Δ
rust 73.03% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/lib.rs 2.38% <ø> (ø)
src/meta/src/manager/streaming_job.rs 0.00% <0.00%> (ø)
src/meta/src/rpc/service/ddl_service.rs 3.08% <0.00%> (+0.14%) ⬆️
src/meta/src/stream/stream_graph.rs 69.45% <0.00%> (+0.55%) ⬆️
...torage/src/hummock/local_version/pinned_version.rs 88.30% <0.00%> (-0.59%) ⬇️
src/meta/src/hummock/mock_hummock_meta_client.rs 65.78% <0.00%> (-0.53%) ⬇️
src/common/src/types/ordered_float.rs 31.25% <0.00%> (+0.19%) ⬆️
...frontend/src/scheduler/hummock_snapshot_manager.rs 60.47% <0.00%> (+0.47%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@xx01cyx xx01cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 7adbb6c into main Jan 10, 2023
@mergify mergify bot deleted the bz/extract-fill-id branch January 10, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants