-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce watermark on source #7750
Merged
+464
−56
Merged
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
75f5652
bind and plan
yuhao-su 2c6f844
Merge branch 'main' of github.com:singularity-data/risingwave into yu…
yuhao-su 26486fc
fix
yuhao-su 6c2e9c0
dashboard
yuhao-su 6ac1fae
parser test
yuhao-su 3d680ea
watermark idx proto
yuhao-su 96c89e4
resolve conversation
yuhao-su edafbe3
dashborad
yuhao-su 6e217c3
planner test
yuhao-su 970e6fd
Merge branch 'main' of github.com:singularity-data/risingwave into yu…
yuhao-su 6d14551
ExprRewritable
yuhao-su 1dda95b
resolve conflict
yuhao-su e47e7f6
Merge branch 'main' into yuhao/watermark_source
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
// Copyright 2023 RisingWave Labs | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
use itertools::Itertools; | ||
use risingwave_common::catalog::Field; | ||
use risingwave_common::error::Result; | ||
|
||
use crate::catalog::column_catalog::ColumnCatalog; | ||
use crate::Binder; | ||
|
||
impl Binder { | ||
pub fn bind_columns_to_context( | ||
&mut self, | ||
name: String, | ||
column_catalogs: Vec<ColumnCatalog>, | ||
) -> Result<()> { | ||
let columns = column_catalogs | ||
.iter() | ||
.map(|c| (c.is_hidden, Field::from(&c.column_desc))) | ||
.collect_vec(); | ||
self.bind_table_to_context(columns, name, None) | ||
} | ||
|
||
pub fn get_column_binding_index( | ||
&mut self, | ||
table_name: String, | ||
column_name: &String, | ||
) -> Result<usize> { | ||
Ok(self | ||
.context | ||
.get_column_binding_index(&Some(table_name), column_name)?) | ||
} | ||
st1page marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry.
repeated
field is compatible with non-repeated one, so you may leave them as non-repeated now and change it until needed, in order to make the code cleaner.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already changed🤣