Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta): separate stream graph building into modules & add unit tests for scheduler #7807

Merged
merged 7 commits into from
Feb 9, 2023

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Feb 9, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

There are no substantial changes except for the unit test for the new scheduler.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Comment on lines +371 to +372
#[cfg(test)]
mod tests {
Copy link
Member Author

@BugenZhao BugenZhao Feb 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here're the unit tests.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #7807 (dd65324) into main (42f37b5) will increase coverage by 0.00%.
The diff coverage is 78.59%.

@@           Coverage Diff            @@
##             main    #7807    +/-   ##
========================================
  Coverage   71.68%   71.69%            
========================================
  Files        1103     1105     +2     
  Lines      176072   176180   +108     
========================================
+ Hits       126211   126306    +95     
- Misses      49861    49874    +13     
Flag Coverage Δ
rust 71.69% <78.59%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/stream/test_fragmenter.rs 99.33% <ø> (ø)
src/meta/src/stream/stream_graph/visit.rs 58.09% <58.09%> (ø)
src/meta/src/stream/stream_graph/actor.rs 75.89% <75.89%> (ø)
src/meta/src/stream/stream_graph/fragment.rs 80.55% <80.55%> (ø)
src/meta/src/stream/stream_graph/id.rs 83.33% <83.33%> (ø)
src/meta/src/stream/stream_graph/schedule.rs 92.83% <100.00%> (+5.19%) ⬆️
src/batch/src/executor/group_top_n.rs 68.23% <0.00%> (-6.48%) ⬇️
src/meta/src/hummock/mock_hummock_meta_client.rs 63.45% <0.00%> (-1.02%) ⬇️
src/object_store/src/object/mod.rs 51.30% <0.00%> (-0.22%) ⬇️
src/common/src/types/ordered_float.rs 30.87% <0.00%> (-0.20%) ⬇️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify
Copy link
Contributor

mergify bot commented Feb 9, 2023

Hey @BugenZhao, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with git commit --allow-empty -m "rerun" && git push.

…aph-modules

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@mergify mergify bot merged commit e4f2d2f into main Feb 9, 2023
@mergify mergify bot deleted the bz/separate-stream-graph-modules branch February 9, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meta: refactor graph building and scheduling
2 participants