Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove unused deps #7816

Merged
merged 6 commits into from
Feb 9, 2023
Merged

build: remove unused deps #7816

merged 6 commits into from
Feb 9, 2023

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Feb 9, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

With the help of cargo-machete

@xxchan xxchan force-pushed the xxchan/coastal-fowl branch from 01e7ea4 to 3654762 Compare February 9, 2023 13:19
@xxchan
Copy link
Member Author

xxchan commented Feb 9, 2023

Debug build is even more faster, but the critial path is still only improved a little, if any 🥵

image

@xxchan
Copy link
Member Author

xxchan commented Feb 9, 2023

@kwannoel How can I ignore fuzz test? 🥵

@kwannoel
Copy link
Contributor

kwannoel commented Feb 9, 2023

rerun pipeline, fuzz-test is probabilistic, only e2e deterministic test will fail continuously :P

Issue you encounter should be fixed here: #7815.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #7816 (655eabd) into main (037f51a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #7816   +/-   ##
=======================================
  Coverage   71.72%   71.73%           
=======================================
  Files        1106     1106           
  Lines      176247   176247           
=======================================
+ Hits       126412   126426   +14     
+ Misses      49835    49821   -14     
Flag Coverage Δ
rust 71.73% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/cache.rs 97.15% <0.00%> (-0.11%) ⬇️
src/storage/src/hummock/sstable_store.rs 64.89% <0.00%> (+0.15%) ⬆️
src/storage/src/hummock/compactor/mod.rs 80.85% <0.00%> (+0.19%) ⬆️
src/storage/src/hummock/compactor/iterator.rs 98.24% <0.00%> (+0.29%) ⬆️
src/object_store/src/object/mem.rs 87.25% <0.00%> (+0.38%) ⬆️
src/batch/src/executor/group_top_n.rs 74.70% <0.00%> (+6.47%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit d6f9e2e into main Feb 9, 2023
@mergify mergify bot deleted the xxchan/coastal-fowl branch February 9, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants