Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: try to use private s3 for artifacts #7870

Closed
wants to merge 18 commits into from
Closed

ci: try to use private s3 for artifacts #7870

wants to merge 18 commits into from

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Feb 13, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #7870 (edb4157) into main (45b5e6b) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #7870      +/-   ##
==========================================
- Coverage   71.67%   71.66%   -0.01%     
==========================================
  Files        1111     1111              
  Lines      176936   176936              
==========================================
- Hits       126812   126807       -5     
- Misses      50124    50129       +5     
Flag Coverage Δ
rust 71.66% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/object_store/src/object/mem.rs 86.48% <0.00%> (-0.78%) ⬇️
src/storage/src/hummock/sstable_store.rs 64.57% <0.00%> (-0.32%) ⬇️
src/storage/src/hummock/compactor/iterator.rs 97.95% <0.00%> (-0.30%) ⬇️
src/object_store/src/object/mod.rs 51.19% <0.00%> (-0.22%) ⬇️
src/stream/src/executor/aggregation/minput.rs 96.24% <0.00%> (-0.11%) ⬇️
src/common/src/cache.rs 97.26% <0.00%> (+0.10%) ⬆️
src/storage/src/hummock/compactor/mod.rs 80.85% <0.00%> (+0.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xxchan
Copy link
Member Author

xxchan commented Feb 13, 2023

Traffic between Amazon EC2 and Amazon S3 can leverage up to 100 Gbps of bandwidth to VPC endpoints and public IPs in the same Region.

🤔

Not as fast as I thought (91b6043)

image

image


buildkite s3 is 32s/19s (BTW this is found after splitting the log for docker-compose. The docker start also takes 10+s)

@xxchan
Copy link
Member Author

xxchan commented Feb 13, 2023

1.6GB 12s 🤔

image

slightly decreased to 8s after setting max_concurrent_requests to 20, but no further improvements

@xxchan xxchan changed the title ci: IGNORE ME ci: try to use private s3 for artifacts Feb 13, 2023
@xxchan
Copy link
Member Author

xxchan commented Feb 13, 2023

cc @huangjw806 Do you have any ideas about the results? Is it possible to be even faster? (looks too slow to me) 🤔

buildkite s3 is 32s/19s

This seems good enough, but if we can finish in 1s it will also be very cool 🥵

@xxchan
Copy link
Member Author

xxchan commented Feb 13, 2023

help! i need somebody help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant