feat(meta): support schema change in actor graph builder #7878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
changed the title
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
…-part-1 Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
changed the title
BugenZhao
commented
Feb 14, 2023
| // - For scaling, this is always `None`. | ||
| // - For plan change, the upstream fragment will be changed to a new one, and this will be `Some`. | ||
| // In this case, all the upstream actors should be removed and replaced by the `new` ones. | ||
| optional uint32 new_upstream_fragment_id = 5; |
There was a problem hiding this comment.
We may reuse the Update barrier of scaling for schema change.
| @@ -581,18 +587,12 @@ where | |||
|
|
|||
| // 2. Get the env for streaming jobs. | |||
| let env = StreamEnvironment::from_protobuf(fragment_graph.get_env().unwrap()); | |||
| let default_parallelism = if let Some(Parallelism { parallelism }) = | |||
There was a problem hiding this comment.
We put this into FragmentGraph::new.
BugenZhao
requested review from
yezizp2012 and
chenzl25
and removed request for
yezizp2012
chenzl25
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bugen Zhao i@bugenzhao.com
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR extends the new actor graph builder introduced in #7659 for replacing table plan, and adds the procedure of preparing the
TableFragments. Note that the RPC with the compute nodes is not implemented so this is not utilized by the frontend yet.Building an actor graph for schema change can be similar and symmetric to the MV on MV.
Materializefragments that give the requirements to the distribution of currentChain. We'll generate new dispatchers for the upstreamMaterializein the result.Chainfragments that give the requirements to the distribution of currentMaterialize. We'll generate updates for the merger for the downstreamChainin the result.Related:
Checklist
./risedev check(or alias,./risedev c)Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note