fix: workaround decode error caused by large key #8064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8064 +/- ##
==========================================
+ Coverage 71.32% 71.33% +0.01%
==========================================
Files 1128 1128
Lines 181576 181648 +72
==========================================
+ Hits 129514 129584 +70
- Misses 52062 52064 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…g change add more logs for large key address comments fmt
hzxa21
force-pushed
the
patrick/workaround-large-key.pr
branch
from
d4327d0 to
11cb540
Compare
wcy-fdu
approved these changes
Feb 21, 2023
Li0k
reviewed
Feb 21, 2023
| @@ -25,6 +25,8 @@ use crate::HummockEpoch; | |||
|
|
|||
| pub const EPOCH_LEN: usize = std::mem::size_of::<HummockEpoch>(); | |||
| pub const TABLE_PREFIX_LEN: usize = std::mem::size_of::<u32>(); | |||
| // Max length for key overlap and diff length. See KeyPrefix::encode. | |||
| pub const MAX_KEY_LEN: usize = u16::MAX as usize; | |||
There was a problem hiding this comment.
entry (kv pair): | overlap len (2B) | diff len (2B) | value len(4B) | diff key | value |
Would it be more intuitive to add format to the comment?
Li0k
approved these changes
Feb 21, 2023
lmatz
pushed a commit
that referenced
this pull request
Feb 24, 2023
This is a hotfix to workaround decode error caused by store key larger than 64KB. In the future, we may come up with a better way to prevent large key from occuring in the storage (e.g. limit the state table primary key size). Note that this change breaks the format compatibility but in a very limited manner (only if there are keys with exact len=64KB written prior to this PR). Approved-By: soundOfDestiny Approved-By: wcy-fdu Approved-By: wenym1 Approved-By: Li0k
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This is a hotfix to workaround decode error caused by store key larger than 64KB. In the future, we may come up with a better way to prevent large key from occuring in the storage (e.g. limit the state table primary key size).
Note that this change breaks the format compatibility but in a very limited manner (only if there are keys with exact len=64KB written prior to this PR).
Checklist
- [] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features).- [] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)./risedev check(or alias,./risedev c)Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note