Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expr): jsonb IS [NOT] NULL #8256

Merged
merged 1 commit into from
Mar 1, 2023
Merged

feat(expr): jsonb IS [NOT] NULL #8256

merged 1 commit into from
Mar 1, 2023

Conversation

xiangjinwu
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Add the missing support to use jsonb as input to IS [NOT] NULL. Also add tests for similar functions that are supposed to work for all types: CASE WHEN, COALESCE.

Note that bytea will be handled separately. Functions based on comparison (e.g. IS DISTINCT FROM, NULLIF, IN) are left out purposely.

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added an item to track fuzzing tests.
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

Types of user-facing changes

  • SQL commands, functions, and operators

Release note

Support jsonb IS [NOT] NULL.

@github-actions github-actions bot added type/feature user-facing-changes Contains changes that are visible to users labels Mar 1, 2023
@xiangjinwu xiangjinwu requested review from BugenZhao and lmatz March 1, 2023 06:45
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #8256 (e3bff44) into main (c75863a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #8256   +/-   ##
=======================================
  Coverage   71.60%   71.61%           
=======================================
  Files        1132     1132           
  Lines      183384   183385    +1     
=======================================
+ Hits       131308   131322   +14     
+ Misses      52076    52063   -13     
Flag Coverage Δ
rust 71.61% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expr/src/sig/func.rs 94.28% <100.00%> (+0.02%) ⬆️
src/batch/src/task/task_execution.rs 51.75% <0.00%> (-0.51%) ⬇️
src/storage/src/hummock/compactor/mod.rs 80.38% <0.00%> (ø)
src/meta/src/hummock/manager/mod.rs 75.68% <0.00%> (+0.06%) ⬆️
src/common/src/types/ordered_float.rs 31.06% <0.00%> (+0.19%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 65.46% <0.00%> (+1.03%) ⬆️
src/batch/src/executor/group_top_n.rs 74.70% <0.00%> (+6.47%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangjinwu xiangjinwu added this pull request to the merge queue Mar 1, 2023
Merged via the queue into main with commit 177a6cb Mar 1, 2023
@xiangjinwu xiangjinwu deleted the feat-jsonb-is-null branch March 1, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants