Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply column-aware row encoding & enable schema change #8394

Merged
merged 14 commits into from
Mar 9, 2023
Merged

feat: apply column-aware row encoding & enable schema change #8394

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c0ccdcf
version field, either serde, integrate with materialize
BugenZhao Mar 7, 2023
24d256f
add generic to materialize
BugenZhao Mar 7, 2023
4599da5
turn off sanity check
BugenZhao Mar 7, 2023
245b567
add fake generic
BugenZhao Mar 7, 2023
7f56be9
disable schema change for table with connector
BugenZhao Mar 7, 2023
b355c8c
fill default id
BugenZhao Mar 7, 2023
8f94036
remove notice and enable in production
BugenZhao Mar 7, 2023
6b788b8
Merge remote-tracking branch 'origin/main' into bz/column-aware-row-e…
BugenZhao Mar 7, 2023
966d290
enable table version for table with connector
BugenZhao Mar 7, 2023
7fcfeb3
fix encoding
BugenZhao Mar 7, 2023
0ba116e
Merge remote-tracking branch 'origin/main' into bz/column-aware-row-e…
BugenZhao Mar 8, 2023
82a4133
extend e2e tests
BugenZhao Mar 8, 2023
cae0e81
refine comments
BugenZhao Mar 8, 2023
5924af6
support column-aware serde
BugenZhao Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/common/src/util/value_encoding/column_aware_row_encoding.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,13 @@ impl RowEncoding {
self.flag |= Flag::OFFSET16;
usize_offsets
.iter()
.for_each(|m| self.offsets.put_u16(*m as u16));
.for_each(|m| self.offsets.put_u16_le(*m as u16));
BugenZhao marked this conversation as resolved.
Show resolved Hide resolved
}
_n @ ..=const { u32::MAX as usize } => {
self.flag |= Flag::OFFSET32;
usize_offsets
.iter()
.for_each(|m| self.offsets.put_u32(*m as u32));
.for_each(|m| self.offsets.put_u32_le(*m as u32));
}
_ => unreachable!("encoding length exceeds u32"),
}
Expand Down
4 changes: 1 addition & 3 deletions src/meta/src/stream/stream_graph/fragment.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@ use anyhow::Context;
use enum_as_inner::EnumAsInner;
use itertools::Itertools;
use risingwave_common::bail;
use risingwave_common::catalog::{
generate_internal_table_name_with_type, TableId, INITIAL_TABLE_VERSION_ID,
};
use risingwave_common::catalog::{generate_internal_table_name_with_type, TableId};
use risingwave_pb::catalog::Table;
use risingwave_pb::meta::table_fragments::fragment::FragmentDistributionType;
use risingwave_pb::meta::table_fragments::Fragment;
Expand Down