Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): decimal round digits test #8568

Merged
merged 4 commits into from
Mar 16, 2023
Merged

fix(common): decimal round digits test #8568

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
84a4146
bump dependency
odysa Mar 15, 2023
26eb36d
fix round_digits test
odysa Mar 15, 2023
de3d489
Update src/expr/src/vector_op/round.rs
odysa Mar 16, 2023
53ba133
fix linr
odysa Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/expr/src/vector_op/round.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ mod tests {
do_test("84818.33333333333333333333333", 4, "84818.3333");
do_test("84818.15", 1, "84818.2");
do_test("21.372736", -1, "0");
// Maximum of 28 digits
do_test("0", 340, &format!("0.{}", "0".repeat(28)));
// should be "0"
odysa marked this conversation as resolved.
Show resolved Hide resolved
do_test("0", 340, "0");
}

#[test]
Expand Down