Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(batch): make Project concurrent to accelerate async exprs #8703

Merged
merged 5 commits into from
Mar 27, 2023

Conversation

TennyZhuang
Copy link
Contributor

@TennyZhuang TennyZhuang commented Mar 22, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title

Please do some benchmark @wangrunji0408

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Signed-off-by: TennyZhuang <zty0826@gmail.com>
Copy link
Contributor

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Signed-off-by: TennyZhuang <zty0826@gmail.com>
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #8703 (f4267a3) into main (9e774bb) will increase coverage by 0.00%.
The diff coverage is 96.15%.

@@           Coverage Diff           @@
##             main    #8703   +/-   ##
=======================================
  Coverage   70.99%   70.99%           
=======================================
  Files        1166     1166           
  Lines      192565   192590   +25     
=======================================
+ Hits       136704   136726   +22     
- Misses      55861    55864    +3     
Flag Coverage Δ
rust 70.99% <96.15%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/project.rs 77.51% <96.15%> (+4.44%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/batch/src/executor/project.rs Outdated Show resolved Hide resolved
src/batch/src/executor/project.rs Outdated Show resolved Hide resolved
TennyZhuang and others added 3 commits March 22, 2023 14:56
@TennyZhuang TennyZhuang added this pull request to the merge queue Mar 27, 2023
Merged via the queue into main with commit 47cfacc Mar 27, 2023
@TennyZhuang TennyZhuang deleted the perf/concurrent-project branch March 27, 2023 08:04
@fuyufjh
Copy link
Member

fuyufjh commented Mar 28, 2023

For this PR I think you might need to check and post the benchmark result before merging.

- [ ] I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.
<!-- To manually trigger a benchmark, please check out [Notion](https://www.notion.so/risingwave-labs/Manually-trigger-nexmark-performance-dashboard-test-b784f1eae1cf48889b2645d020b6b7d3). -->

Check that link: https://www.notion.so/risingwave-labs/Manually-trigger-nexmark-performance-dashboard-test-b784f1eae1cf48889b2645d020b6b7d3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

@TennyZhuang TennyZhuang changed the title perf(stream): make Project concurrent to accelerate async exprs perf(batch): make Project concurrent to accelerate async exprs Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants