Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(streaming): support StreamValues #8751

Merged
merged 21 commits into from
Mar 30, 2023
Merged

feat(streaming): support StreamValues #8751

merged 21 commits into from
Mar 30, 2023

Conversation

y-wei
Copy link
Contributor

@y-wei y-wei commented Mar 23, 2023 •
edited
Loading

Signed-off-by: Clearlove yifei.c.wei@gmail.comI hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

support values in stream execution

Please explain IN DETAIL what the changes are in this PR and why they are needed:

-->

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
    - [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • SQL commands, functions, and operators

Release note

`values` is enabled in materialized view

y-wei added 6 commits March 21, 2023 14:56
@y-wei
introduce and
3120ef3 
Signed-off-by: Clearlove <yifei.c.wei@gmail.com>
@y-wei
runable
59edb42 
Signed-off-by: Clearlove <yifei.c.wei@gmail.com>
@y-wei
comment
f8b40b4 
Signed-off-by: Clearlove <yifei.c.wei@gmail.com>
@y-wei
update planner test
2f22567 
Signed-off-by: Clearlove <yifei.c.wei@gmail.com>
@y-wei
e2e tests
0e05858 
Signed-off-by: Clearlove <yifei.c.wei@gmail.com>
@y-wei
check
ad78363 
Signed-off-by: Clearlove <yifei.c.wei@gmail.com>
@y-wei y-wei requested review from st1page, xx01cyx and BugenZhao March 23, 2023 17:56
@y-wei
Copy link
Contributor Author

y-wei commented Mar 24, 2023 •
edited
Loading

Any ideas about the java build failure? 🥲 Solved

y-wei added 2 commits March 23, 2023 23:35
@y-wei
rename variants in FragmentTypeFlag to avoid collision
b51655c 
Signed-off-by: Clearlove <yifei.c.wei@gmail.com>
@y-wei
check
f3c0587 
Signed-off-by: Clearlove <yifei.c.wei@gmail.com>
@xxchan xxchan added the user-facing-changes Contains changes that are visible to users label Mar 24, 2023
BugenZhao
BugenZhao reviewed Mar 28, 2023
View reviewed changes
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. For the optimizer part @st1page PTAL. 🥰

src/frontend/src/optimizer/plan_node/stream_row_id_gen.rs Outdated Show resolved Hide resolved
src/frontend/src/optimizer/plan_node/logical_row_id_gen.rs Outdated Show resolved Hide resolved
src/frontend/src/optimizer/plan_node/mod.rs Outdated Show resolved Hide resolved
src/frontend/src/optimizer/plan_node/mod.rs Outdated Show resolved Hide resolved
src/frontend/src/optimizer/plan_node/mod.rs Outdated Show resolved Hide resolved
src/frontend/src/optimizer/plan_node/logical_values.rs Outdated Show resolved Hide resolved
src/stream/src/executor/mod.rs Outdated Show resolved Hide resolved
src/stream/src/executor/values.rs Outdated Show resolved Hide resolved
src/stream/src/executor/values.rs Outdated Show resolved Hide resolved
src/stream/src/executor/values.rs Outdated Show resolved Hide resolved
@y-wei
Copy link
Contributor Author

y-wei commented Mar 28, 2023

Thanks for your insightful comments! I'll give a new version by the end of today😄

y-wei added 9 commits March 28, 2023 15:28
@y-wei
remove logical_row_id_gen
b8901ae 
Signed-off-by: Clearlove <yifei.c.wei@gmail.com>
@y-wei
Merge branch 'main' of github.com:singularity-data/risingwave into Eu…
5e9b209 
…rekaaw/issue8635
@y-wei
other refractor
856635e 
Signed-off-by: Clearlove <yifei.c.wei@gmail.com>
@y-wei
planner test
9cd021f 
Signed-off-by: Clearlove <yifei.c.wei@gmail.com>
@y-wei
more refractor
eff23bb 
Signed-off-by: Clearlove <yifei.c.wei@gmail.com>
@y-wei
check
d122214
@y-wei
use streamexecutortestext
988dbb8
@y-wei
report create mv progress
2fb8d74 
Signed-off-by: Clearlove <yifei.c.wei@gmail.com>
@y-wei
register values' actor to meta
c9f76da
BugenZhao
BugenZhao approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@y-wei y-wei enabled auto-merge March 30, 2023 13:46
@y-wei y-wei added this pull request to the merge queue Mar 30, 2023
Merged via the queue into risingwavelabs:main with commit bccc76d Mar 30, 2023
@y-wei y-wei deleted the Eurekaaw/issue8635 branch March 30, 2023 15:04
@y-wei y-wei mentioned this pull request Mar 30, 2023
Closed
@CharlieSYH CharlieSYH added the 📖✓ Covered or will be covered in the user docs. label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st1page st1page st1page left review comments

@BugenZhao BugenZhao BugenZhao approved these changes

@xx01cyx xx01cyx Awaiting requested review from xx01cyx

Assignees
No one assigned
Labels
user-facing-changes Contains changes that are visible to users 📖✓ Covered or will be covered in the user docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@y-wei @BugenZhao @st1page @xxchan @CharlieSYH