Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for cardinality function #8867

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Conversation

Honeta
Copy link
Contributor

@Honeta Honeta commented Mar 29, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

close #8854

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • SQL commands, functions, and operators

Release note

https://www.postgresql.org/docs/current/functions-array.html

@Honeta Honeta requested a review from st1page March 29, 2023 12:58
@github-actions github-actions bot added type/feature user-facing-changes Contains changes that are visible to users labels Mar 29, 2023
Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some e2e tests. Rest LGTM

@Honeta Honeta enabled auto-merge March 30, 2023 05:38
@Honeta Honeta added this pull request to the merge queue Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #8867 (fe84f9a) into main (99a1ca2) will decrease coverage by 0.02%.
The diff coverage is 10.52%.

@@            Coverage Diff             @@
##             main    #8867      +/-   ##
==========================================
- Coverage   70.75%   70.73%   -0.02%     
==========================================
  Files        1174     1175       +1     
  Lines      194889   194908      +19     
==========================================
- Hits       137885   137872      -13     
- Misses      57004    57036      +32     
Flag Coverage Δ
rust 70.73% <10.52%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expr/src/expr/mod.rs 48.71% <ø> (ø)
src/frontend/src/expr/type_inference/func.rs 83.43% <0.00%> (-1.43%) ⬇️
src/expr/src/expr/expr_cardinality.rs 25.00% <25.00%> (ø)
src/frontend/src/binder/expr/function.rs 89.15% <100.00%> (+0.01%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 30, 2023
@Honeta Honeta added this pull request to the merge queue Mar 30, 2023
Merged via the queue into main with commit 5fd0c7d Mar 30, 2023
@Honeta Honeta deleted the xinjing/cardinality_array branch March 30, 2023 06:30
@CharlieSYH CharlieSYH added the 📖✓ Covered or will be covered in the user docs. label Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users 📖✓ Covered or will be covered in the user docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: cardinality array function
3 participants