-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector): support ingest Citus distributed table #8988
Conversation
@fuyufjh I am a little skeptical about this approach. Can we try to deliver the poc on this branch rather than main branch? We can merge the pr after they accept this. |
Codecov Report
@@ Coverage Diff @@
## main #8988 +/- ##
==========================================
- Coverage 70.83% 70.81% -0.02%
==========================================
Files 1201 1201
Lines 200454 200533 +79
==========================================
+ Hits 141992 142013 +21
- Misses 58462 58520 +58
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I am 50-50 on this. Except the refactoring around Let the author @StrikeW make this decision :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM
} | ||
|
||
break; | ||
case MYSQL: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious: why MySQL doesn't need a "Validator"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will but not that urgent. Just because I want to implement the feature ASAP. I will refactor the validation part when I have bandwidth.
...singwave-connector-service/src/main/java/com/risingwave/sourcenode/SourceRequestHandler.java
Outdated
Show resolved
Hide resolved
...singwave-connector-service/src/main/java/com/risingwave/sourcenode/SourceRequestHandler.java
Show resolved
Hide resolved
Could you elaborate more about your concerns? @tabVersion |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Support
citus-cdc
connector for theCREATE TABLE
statement, which allows users to ingest a distributed table stored in Citus to RisingWave. For example, we can ingest the github_events table via the following SQL (don't forget to specify a primary key for the table):Users need to specify the host and port for Citus worker nodes by
database.servers
in the WITH clause.Prerequisites
superuser
role in the Citus clusterwal_level
tological
on each worker node (e.g. modify thepostgresql.conf
)FULL
for the table you want to ingestLimitations
superuser
roleChecklist For Contributors
./risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note
Support
citus-cdc
connector for theCREATE TABLE
statement, which allows users to ingest a distributed table stored in Citus to RisingWave.