-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fronted): cotd implementation #9259
Conversation
static SIND_30: f64 = 0.499_999_999_999_999_94; | ||
static ONE_MINUS_COSD_60: f64 = 0.499_999_999_999_999_9; | ||
static TAND_45: f64 = 1.0; | ||
static COTD_45: f64 = 1.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed these to make sure that we are talking about degrees and not radians
Codecov Report
@@ Coverage Diff @@
## main #9259 +/- ##
=======================================
Coverage 70.81% 70.81%
=======================================
Files 1228 1228
Lines 203786 203838 +52
=======================================
+ Hits 144304 144349 +45
- Misses 59482 59489 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Implement the
COTD
function. This implementation is slightly different from the PSQL implementation. I do not return an error onCOTD(Inf)
, but instead returnNaN
.Checklist For Contributors
./risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note
COTD
: An implementation of the cotangent in degrees.